Skip to content

test: fix ResponseTest::testSetDateRemembersDateInUTC#6632

Merged
kenjis merged 3 commits intocodeigniter4:developfrom
kenjis:fix-test-testSetDateRemembersDateInUTC
Oct 7, 2022
Merged

test: fix ResponseTest::testSetDateRemembersDateInUTC#6632
kenjis merged 3 commits intocodeigniter4:developfrom
kenjis:fix-test-testSetDateRemembersDateInUTC

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Oct 6, 2022

Description
Fixes #5486

  • fix tests that depend on time

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Oct 6, 2022
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the new modifiers!

Also: what is the point of this? Clone and replace a brand new object?

Never mind! I see now, the setDate() call is before the clone.

Comment thread tests/system/HTTP/DownloadResponseTest.php Outdated
Comment thread tests/system/HTTP/ResponseTest.php Outdated
kenjis and others added 2 commits October 7, 2022 07:31
Co-authored-by: MGatner <mgatner@icloud.com>
Co-authored-by: MGatner <mgatner@icloud.com>
@kenjis kenjis requested a review from MGatner October 6, 2022 22:32
@kenjis kenjis merged commit df0fa73 into codeigniter4:develop Oct 7, 2022
@kenjis kenjis deleted the fix-test-testSetDateRemembersDateInUTC branch October 7, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ResponseTest::testSetDateRemembersDateInUTC depends on time

3 participants